-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce gpu
kwarg to Context.__init__
, deprecate for create_table
#1117
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 81.76% 81.52% -0.24%
==========================================
Files 78 78
Lines 4397 4443 +46
Branches 792 801 +9
==========================================
+ Hits 3595 3622 +27
- Misses 631 637 +6
- Partials 171 184 +13
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Having a GPU flag set at the context level should allow us to more easily make assumptions when doing things such as:
AnalyzeTable
orEmptyRelation
plugins)Assume the majority of the work here will be test refactoring to get things passing, but hopeful that this will make it a little easier to generalize CPU/GPU tests moving forward.