Switch from skipping to xfailing some Python tests #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1002 +/- ##
==========================================
+ Coverage 78.56% 80.90% +2.33%
==========================================
Files 77 77
Lines 4330 4330
Branches 778 778
==========================================
+ Hits 3402 3503 +101
+ Misses 756 649 -107
- Partials 172 178 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charlesbluca
commented
Jan 23, 2023
| @@ -903,7 +903,6 @@ def test_ml_experiment(c, client, training_df): | |||
|
|
|||
| # TODO - many ML tests fail on clusters without sklearn - can we avoid this? | |||
| @xfail_if_external_scheduler | |||
| @pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280") | |||
There was a problem hiding this comment.
cc @sarahyurick since this is your PR; are you aware of any other upstream changes that could've resolved these failures?
There was a problem hiding this comment.
AFAIK, the only other solution is to restrict the NumPy version to be < 1.24.0
ayushdg
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some remaining
pytest.mark.skipsthat weren't caught in #867; interested to see if any of these are passing now