Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): ignore abci section on seeds #785

Merged
merged 2 commits into from May 10, 2024
Merged

fix(config): ignore abci section on seeds #785

merged 2 commits into from May 10, 2024
+81 −10

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented May 9, 2024 •
edited

Issue being fixed or feature implemented

On seeds, [abci] section is unused and should be ignored.

What was done?

  • ignore [abci] section on seed nodes
  • report errors from multiple sections at one run

How Has This Been Tested?

Added unit test

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review May 9, 2024 12:13
@lklimek lklimek merged commit 29b4ef9 into v0.14-dev May 10, 2024
15 checks passed
@lklimek lklimek deleted the fix/config-seed-no-abci branch May 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lklimek @QuantumExplorer