Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Should not check validity for legacy G1 and G2 in FromBytes #58

Merged
merged 2 commits into from Dec 14, 2022

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 13, 2022

Fixes an issue introduced in ffd1622 via #44 (dropped if while moving from ffd1622#diff-f486cfa221391360bf21a00b48ddd8c47fc27116db3454e782e3e942d9b5b45bR83 to ffd1622#diff-f486cfa221391360bf21a00b48ddd8c47fc27116db3454e782e3e942d9b5b45bR26).

Should fix dashpay/dash#5077 (comment) (I reindexed on testnet with this patch applied on top of develop and had no issues).

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PastaPastaPasta PastaPastaPasta merged commit 85b7e61 into dashpay:develop Dec 14, 2022
@UdjinM6 UdjinM6 deleted the do_not_check_legacy branch December 20, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants