Fix warnings during the "Bundling to UMD"

[flavens]

It resolves the following warnings during the project build:

closes #49

YouTrack issue: https://dasch.myjetbrains.com/youtrack/issue/DSP-51

[tobiasschweizer]

I wonder why there is jdnconvertiblecalendar and JDNConvertibleCalendar. jdnconvertiblecalendar/dist/src/JDNConvertibleCalendar seems odd. Maybe I did something wrong in https://github.com/dhlab-basel/JDNConvertibleCalendar, I will check this.

[tobiasschweizer]

I found the problem:

https://github.com/dasch-swiss/knora-ui-ng-lib/blob/373e762ac7dcab0f8c9894fde830c749aba96ca7/projects/knora-ui/src/lib/viewer/values/time-value/time-input/time-input.component.ts#L7-L9

The imports have to be changed to (JDNConvertibleCalendarModule is not needed):

import {CalendarDate, CalendarPeriod, GregorianCalendarDate} from 'jdnconvertiblecalendar';

and then

https://github.com/dasch-swiss/knora-ui-ng-lib/blob/6d211c58da73c7c4eb8695a0c6c68fc2fca1bb62/projects/knora-ui/ng-package.json#L11

becomes obsolete.

[tobiasschweizer]

I wonder if we have to do something about

WARNING: 'ReadValue', 'ReadTextValueAsString', 'ReadIntValue', 'ReadLinkValue', 'ReadBooleanValue', 'ReadDecimalValue', 'ReadColorValue', 'ReadUriValue', 'ReadIntervalValue' and 'ReadTimeValue' are imported from external module '@knora/api' but never used

I found angular/angular#21280 which you have already mentioned :-)

[tobiasschweizer]

Looks good, thanks!

[flavens]

I found angular/angular#21280 which you have already mentioned :-)

I tried the solution with emitDecoratorMetadata sets to true but it did not change anything...

[tobiasschweizer]

I found angular/angular#21280 which you have already mentioned :-)

I tried the solution with emitDecoratorMetadata sets to true but it did not change anything...

I think it's not a real problem.

[tobiasschweizer]

probably it's just some imports that are still in the JavaScript code that's generated from the TypeScript source, but in JavaScript these classes are not used since the refer to TypeScript constructs

[tobiasschweizer]

so this PR is good to go :-)