Fix WARNING: No name was provided for external module "xxx" in output.globals – guessing "xxx"

[flavens]

Issue in terminal when building the library knora-ui

Solution

• add the following lines to ng-package.json and ng-package.prod.json

{
    ...
    "lib": {
       ...,
        "umdModuleIds": {
            "@knora/api": "@knora/api",
            "ngx-color-picker": "ngxColorPicker",
            "jdnconvertiblecalendar": "jdnconvertiblecalendar",
            "jdnconvertiblecalendardateadapter": "jdnconvertiblecalendardateadapter",
            "jdnconvertiblecalendar/dist/src/JDNConvertibleCalendar": "JDNConvertibleCalendar"
        }
    }
}

[tobiasschweizer]

I already wondered about this warning, great!

[flavens]

If it is ok with you, I would like to open a PR to fix issue #49 (this one) and #48 together. It's just chore changes. But #48 may bring some breaking changes because all path to knora-ui will have to be updated to @knora-ui. Of course I will update as many files as I can in the PR.

[flavens]

For information about the other warnings during the built:
WARNING: 'ReadValue', 'ReadTextValueAsString', 'ReadIntValue', 'ReadResource', 'ReadBooleanValue', 'ReadDecimalValue', 'ReadColorValue', 'ReadUriValue', 'ReadIntervalValue', 'ReadTimeValue' and 'PropertyDefinition' are imported from external module '@knora/api' but never used

-> it comes from angular-cli but there is no fix at the moment:
angular/angular#21280
ng-packagr/ng-packagr#710

[tobiasschweizer]

If it is ok with you, I would like to open a PR to fix issue #49 (this one) and #48 together. It's just chore changes. But #48 may bring some breaking changes because all path to knora-ui will have to be updated to @knora-ui. Of course I will update as many files as I can in the PR.

Could we wait with #48 until all value components have been implemented?

[flavens]

Could we wait with #48 until all value components have been implemented?

yes, I can wait this both issues because fixing the warnings is not an emergency...