-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev into main #677
Merge dev into main #677
Conversation
As you mentioned here, we need to decide whether to keep If we're gonna keep it here, I'd like to propose some changes to both the |
My rationale for including it here is that it's a COM interface that is part of the Win32 metadata (namespace of |
I removed IInspectable extension methods and added them as top-level functions instead (inspired by How do I access and customize the IInspectable methods of a Windows Runtime class written in C++/WinRT?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halildurmus Are we ready to review and potentially merge this? There is probably some back and forth between us, but I'd like to move forward if we can!