Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial implementation of a github actions reporter #1678

Merged
merged 15 commits into from Mar 30, 2022
Merged

initial implementation of a github actions reporter #1678

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
68858c7
initial implementation of a github actions reporter
devoncarew Mar 18, 2022
84c3797
remove newlines from test titles
devoncarew Mar 18, 2022
4554787
some output tweaks
devoncarew Mar 18, 2022
e86c5b0
better visualize setUpAll, tearDownAll, and loadSuite LiveTests
devoncarew Mar 19, 2022
0dbb2b9
tweak the icons used
devoncarew Mar 19, 2022
cb3e6d4
more teaks to icons
devoncarew Mar 19, 2022
cea45ef
adjust success method and icons
devoncarew Mar 20, 2022
2cbf943
add tests
devoncarew Mar 22, 2022
f0d7d23
fix a test in runner_test.dart
devoncarew Mar 22, 2022
c75e201
update readme and changelog
devoncarew Mar 23, 2022
656e10e
Merge branch 'master' into github_actions_reporter
devoncarew Mar 23, 2022
554dafa
Update README.md
devoncarew Mar 23, 2022
ca40a35
Update github.dart
devoncarew Mar 23, 2022
1d99df6
review updates
devoncarew Mar 29, 2022
d8d521d
switch to using the checkmark icon for synthetic tests
devoncarew Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkgs/test_core/lib/src/runner/reporter/github.dart
View file
Open in desktop
Expand Up @@ -101,6 +101,7 @@ class GithubReporter implements Reporter {
final failed = errors.isNotEmpty;

void emitMessages(List<Message> messages) {
// todo: escape some github commands? ::group::, ::endgroup::, ::error::, ...
for (var message in messages) {
_sink.writeln(message.text);
}
Expand All @@ -113,6 +114,9 @@ class GithubReporter implements Reporter {
}
}

// TODO: how to recognize (setUpAll) and (tearDownAll)?
devoncarew marked this conversation as resolved.
Show resolved Hide resolved
// And are they reported in the 'passed test' count from the engine?

final isLoadSuite = test.suite is LoadSuite;
if (isLoadSuite) {
// Don't emit any info for 'loadSuite' tests, unless they contain errors.
Expand Down Expand Up @@ -152,19 +156,18 @@ class GithubReporter implements Reporter {
_sink.writeln();

final hadFailures = _engine.failed.isNotEmpty;
String message =
'${_engine.passed.length} ${pluralize('test', _engine.passed.length)} passed';
var message = '${_engine.passed.length} '
'${pluralize('test', _engine.passed.length)} passed';
if (_engine.failed.isNotEmpty) {
message += ', ${_engine.failed.length} failed';
}
if (_engine.skipped.isNotEmpty) {
message += ', ${_engine.skipped.length} skipped';
}
message += '.';
_sink.writeln(
hadFailures
? _helper.error(message)
: '${_GithubHelper.celebrationIcon} $message',
: '$message ${_GithubHelper.celebrationIcon}',
);
}

Expand Down