Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some retry around browser launching #1676

Merged
merged 5 commits into from Mar 16, 2022
Merged

Add some retry around browser launching #1676

merged 5 commits into from Mar 16, 2022

Commits on Mar 16, 2022

  1. Add some retry around browser launching 

    Towards #1578

Recursively attempt to launch the browser on the first few timeouts
before throwing the ApplicationException.
    @natebosch
    natebosch committed Mar 16, 2022
    Copy the full SHA
    a55704a View commit details
    Browse the repository at this point in the history

  2. Restore previous timeout of 30 seconds 

    The 45 second timeout was mainly to investigate whether extra time would
resolve flakes. It didn't seem to help at all and it doesn't seem likely
that even more time would help. Go back to 30 seconds to reduce the pain
of hitting retries (though it will still be painful).
    @natebosch
    natebosch committed Mar 16, 2022
    Copy the full SHA
    675245b View commit details
    Browse the repository at this point in the history

  3. Add changelog

    @natebosch
    natebosch committed Mar 16, 2022
    Copy the full SHA
    742b563 View commit details
    Browse the repository at this point in the history

  4. Don't retry forever

    @natebosch
    natebosch committed Mar 16, 2022
    Copy the full SHA
    1d7a67b View commit details
    Browse the repository at this point in the history

  5. Drop -dev to publish without another PR

    @natebosch
    natebosch committed Mar 16, 2022
    Copy the full SHA
    c7ff54d View commit details
    Browse the repository at this point in the history