Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate back to ConstructorName.type from ConstructorName.type2 #1673

Merged
merged 1 commit into from Mar 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/test_core/CHANGELOG.md
Expand Up @@ -3,6 +3,7 @@
* Remove wait for VM platform isolate exits.
* Drop `dart2jsPath` configuration support.
* Allow loading tests under a path with the directory named `packages`.
* Require analyzer version `3.3.0`.

## 0.4.11

Expand Down
4 changes: 2 additions & 2 deletions pkgs/test_core/lib/src/runner/parse_metadata.dart
Expand Up @@ -220,7 +220,7 @@ class _Parser {
for (var expression in expressions) {
if (expression is InstanceCreationExpression) {
var className = _resolveConstructor(
expression.constructorName.type2.name,
expression.constructorName.type.name,
expression.constructorName.name)
.first;

Expand Down Expand Up @@ -356,7 +356,7 @@ class _Parser {

String? _findConstructornameFromInstantiation(
InstanceCreationExpression constructor, String className) {
var pair = _resolveConstructor(constructor.constructorName.type2.name,
var pair = _resolveConstructor(constructor.constructorName.type.name,
constructor.constructorName.name);
var actualClassName = pair.first;
var constructorName = pair.last;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/test_core/pubspec.yaml
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: '>=2.14.0 <3.0.0'

dependencies:
analyzer: '>=2.4.0 <4.0.0'
analyzer: '>=3.3.0 <4.0.0'
async: ^2.5.0
args: ^2.0.0
boolean_selector: ^2.1.0
Expand Down
Empty file added type
Empty file.