Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev to 3.0.0-beta in preparation for publishing #153

Merged
merged 2 commits into from
Sep 26, 2023
Merged

rev to 3.0.0-beta in preparation for publishing #153

merged 2 commits into from
Sep 26, 2023

Conversation

devoncarew
Copy link
Member

  • rev to 3.0.0-beta in preparation for publishing

I'd like to publish this as 3.0.0-beta (pre-release) in order to run the current lint set through a few code bases; that'll let us make sure the changes in analysis are ~what we'd expect.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from pq September 25, 2023 23:18
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:lints 3.0.0-beta ready to publish v3.0.0-beta

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@pq
Copy link
Member

pq commented Sep 26, 2023

I've made a late-breaking proposal for 3.0 in #154.

If you feel comfortable, I'm OK with landing this before we reach a decision on that. (I think we can still remove prefer_void_to_null for 3.0 even if there's a beta out that still has it.)

@devoncarew
Copy link
Member Author

I've made a late-breaking proposal for 3.0 in #154.

If you feel comfortable, I'm OK with landing this before we reach a decision on that. (I think we can still remove prefer_void_to_null for 3.0 even if there's a beta out that still has it.)

Gotcha; this beta may not be the final word for 3.0.0; we still need to look into the analysis toggles around unintentional use of dynamic. We'll still have time to look at #154 and see if we think it should be in this release or no.

@devoncarew devoncarew merged commit c266a04 into main Sep 26, 2023
4 checks passed
@devoncarew devoncarew deleted the rev_dev branch September 26, 2023 15:53
@devoncarew
Copy link
Member Author

Looks like publishing automation here failed - Pubspec version (3.0.0-beta) and git tag (v3.0.0-beta) don't agree.. Perhaps due to incomplete handling of -beta versions? I'll manually publish from the tag and file an issue on firehose.

@devoncarew
Copy link
Member Author

dart-lang/ecosystem#176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants