Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document which lints are in core and recommended #129

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jun 2, 2023

This PR generates the list of list in core and recommended into the readme, and verifies that the list is up-to-date on the CI. It does add dart code to the repo, but only in tool/, and keeps the check that we don't inadvertently add code to lib/.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@pq for review; @mit-mit for changes to the readme (nothing semantic)

@parlough for fyi re: linking to the https://dart.dev/lints/<code> urls

@devoncarew devoncarew requested review from pq and mit-mit June 2, 2023 15:58
@devoncarew
Copy link
Member Author

Screenshot 2023-06-02 at 8 59 07 AM

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Nice!

@parlough
Copy link
Member

parlough commented Jun 2, 2023

Love it!

@devoncarew devoncarew merged commit 4e4c18f into main Jun 2, 2023
3 checks passed
@devoncarew devoncarew deleted the doc_lints branch June 2, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the current set of core and recommended lints to the readme.md file
3 participants