Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analysis errors #3686

Closed
wants to merge 1 commit into from
Closed

Fix analysis errors #3686

wants to merge 1 commit into from

Conversation

natebosch
Copy link
Member

  • Remove usage of deprecated withNullability argument from the
    analyzer.
  • Use https URLs in fixture package pubspec files.
  • Sort dependencies in a fixture package pubspec file.

@natebosch
Fix analysis errors
c81a5e1 
- Remove usage of deprecated `withNullability` argument from the
  analyzer.
- Use https URLs in fixture package pubspec files.
- Sort dependencies in a fixture package pubspec file.
@natebosch natebosch requested a review from jakemac53 May 13, 2024 17:01
@jakemac53
Copy link
Contributor

Haha 🤣 #3685

@natebosch natebosch closed this May 13, 2024
@natebosch natebosch deleted the fix-diagnostics branch May 13, 2024 17:03
@jakemac53
Copy link
Contributor

There is a larger issue here though, the latest analyzer is only actually available on 3.4.0-256.0.dev and higher (because of its dependency on package:_macros, which is only available on that version).

I think we want to wait for 3.4.0 stable, and require that as the new minimum across everything.

@natebosch
Copy link
Member Author

Waiting for the next stable SDK sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natebosch @jakemac53