Support for resolving package config and pubspec.lock in workspaces

[sigurdm]

Instead of expecting pubspec.lock and .dart_tool/package_config.json to reside in the same folder as pubspec.yaml, we visit each parent of the current directory until we find a .dart_tool/package_config.json, and expect pubspec.lock to exist next to that.

Also invoke the generated scripts with an explicit packageConfig.

This is to support running build_runner build in a workspace package, as implemented in dart-lang/pub#4127

[sigurdm]

The CI failures seem unrelated.

[sigurdm]

I added a test of the package graph creation.

And support for .packages.

[sigurdm]

Not sure what goes wrong in the community test. I am not able to reproduce the failures locally.

[jakemac53]

Not sure what goes wrong in the community test. I am not able to reproduce the failures locally.

I can look into that, but probably not until next week. Or possibly @simolus3 would have some idea, but it seems like the code just isn't getting generated for some reason.

[simolus3]

The failure looks surprising to me as well. I commit generated code into the repository and the build integrity test shows that re-running build_runner does not alter the state of the checkout. So the generated code should be there.

My best guess is that we hit a race condition where the build integrity test started running (and thus deleting previous generated sources) while the other tests were being loaded, thus causing these errors? I have disabled concurrency for the community tests in the drift repository, I hope that resolves the problem.

[jakemac53]

I have disabled concurrency for the community tests in the drift repository, I hope that resolves the problem.

I restarted the job and it passed 👍

[sigurdm]

Anything more blocking this?

[jonasfj]

This is really another good case for adding the dependency types and relationships in package_config.json. That would much parsing all pubspec.yaml files unnecessary in this case.

[sigurdm]

This is really another good case for adding the dependency types and relationships in package_config.json. That would much parsing all pubspec.yaml files unnecessary in this case.

Yeah - lets do that another time!

dart-lang/pub#3795

[sigurdm]

Gentle ping

[jakemac53]

I can upload a change to address my two nits