Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore stack overflow URLs in link checker #3651

Merged
merged 2 commits into from Feb 27, 2024
Merged

Ignore stack overflow URLs in link checker #3651

merged 2 commits into from Feb 27, 2024

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Feb 20, 2024 •
edited

We get a 403 (forbidden) for these currently. Just ignore them.

I also tried adding a user agent but that didn't seem to help.

@jakemac53 jakemac53 marked this pull request as draft February 20, 2024 19:25
@jakemac53 jakemac53 changed the title Try configuring the link checker to send a user agent to stack overflow URLs Ignore stack overflow URLs in link checker Feb 20, 2024
@jakemac53 jakemac53 marked this pull request as ready for review February 20, 2024 20:28
natebosch
natebosch approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. We shouldn't need to worry about a stack overflow link moving.

@jakemac53 jakemac53 merged commit 0d0de89 into master Feb 27, 2024
70 checks passed
@jakemac53 jakemac53 deleted the link-checker branch February 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakemac53 @natebosch