Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest pkg:js in pkg:build_runner and pkg:build_web_compilers #3640

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jan 11, 2024

Prepare both for publish

@kevmoo kevmoo requested a review from jakemac53 January 11, 2024 18:14
Copy link

github-actions bot commented Jan 11, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:build_modules 5.0.7 ready to publish build_modules-v5.0.7
package:build_runner 2.4.8 ready to publish build_runner-v2.4.8
package:build_web_compilers 4.0.9 ready to publish build_web_compilers-v4.0.9
package:build 2.4.2-wip WIP (no publish necessary)
package:build_config 1.1.2-wip WIP (no publish necessary)
package:build_daemon 4.0.1 already published at pub.dev
package:build_resolvers 2.4.2 already published at pub.dev
package:build_runner_core 7.2.12-wip WIP (no publish necessary)
package:build_test 2.2.2 already published at pub.dev
package:scratch_space 1.0.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@jakemac53
Copy link
Contributor

These failures do look related so we will need to investigate

@@ -6,6 +6,7 @@ import 'package:build_modules/build_modules.dart';

const _libraries = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain always goes to "this should be a Set" but no biggy...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, you aren't wrong, but it also doesn't matter here in practice :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I know. 😉

@kevmoo kevmoo merged commit 8e1cbf8 into master Jan 11, 2024
70 checks passed
@kevmoo kevmoo deleted the latest_pkg_js branch January 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants