Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single builder cycles #3532

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Allow single builder cycles #3532

merged 2 commits into from
Jun 6, 2023

Conversation

natebosch
Copy link
Member

Fixes #3531

When a builder outputs a file with the same extension as a
required_input it will be in a cycle with itself. When builders were
ordered with stronglyConnectedComponents cycles were detected by
looking for a component (cycle) with more than one builder. With the
move to topologicalSort the single builder cycle causes an exception
during the sort. Exclude the builder itself from the list of
dependencies for the graph algorithm call.

Fixes #3531

When a builder outputs a file with the same extension as a
`required_input` it will be in a cycle with itself. When builders were
ordered with `stronglyConnectedComponents` cycles were detected by
looking for a component (cycle) with more than one builder. With the
move to `topologicalSort` the single builder cycle causes an exception
during the sort. Exclude the builder itself from the list of
dependencies for the graph algorithm call.
@natebosch natebosch requested a review from jakemac53 June 6, 2023 17:23
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:build_runner 2.4.5 ready to publish build_runner-v2.4.5
package:build_web_compilers 4.0.4-wip version 4.0.4-wip is pre-release; no publish necessary
package:build 2.4.1-wip version 2.4.1-wip is pre-release; no publish necessary
package:build_config 1.1.2-dev version 1.1.2-dev is pre-release; no publish necessary
package:build_modules 5.0.3-wip version 5.0.3-wip is pre-release; no publish necessary
package:build_daemon 4.0.1-dev version 4.0.1-dev is pre-release; no publish necessary
package:build_runner_core 7.2.10 already published at pub.dev
package:build_resolvers 2.2.1-wip version 2.2.1-wip is pre-release; no publish necessary
package:build_test 2.2.0-wip version 2.2.0-wip is pre-release; no publish necessary
package:scratch_space 1.0.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@natebosch natebosch merged commit ac65c07 into master Jun 6, 2023
65 of 66 checks passed
@natebosch natebosch deleted the single-builder-cycle branch June 6, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is crashing with unhandled exception after upgrade to build_runner 2.4.4
2 participants