Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with package:logger #3515

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix compatibility with package:logger #3515

merged 1 commit into from
May 24, 2023

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented May 23, 2023

Fixes #3514

Add a forwarding implementation of onLevelChanged which was added in
the Logger class.

Update upper bound SDK constraint to avoid pub publish warning.

Remove dependency_overrides section in pubspec.yaml since there is a
separate overrides file.

Add a forwarding implementation of `onLevelChanged` which was added in
the `Logger` class.

Update upper bound SDK constraint to avoid pub publish warning.

Remove `dependency_overrides` section in `pubspec.yaml` since there is a
separate overrides file.
@natebosch natebosch requested a review from kevmoo May 23, 2023 23:36
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:build_runner_core 7.2.9 ready to publish build_runner_core-v7.2.9
package:build_web_compilers 4.0.4-wip version 4.0.4-wip is pre-release; no publish necessary
package:build_runner 2.4.4 already published at pub.dev
package:build 2.4.1-wip version 2.4.1-wip is pre-release; no publish necessary
package:scratch_space 1.0.2 already published at pub.dev
package:build_modules 5.0.3-wip version 5.0.3-wip is pre-release; no publish necessary
package:build_daemon 4.0.1-dev version 4.0.1-dev is pre-release; no publish necessary
package:build_test 2.2.0-wip version 2.2.0-wip is pre-release; no publish necessary
package:build_resolvers 2.2.1-wip version 2.2.1-wip is pre-release; no publish necessary
package:build_config 1.1.2-dev version 1.1.2-dev is pre-release; no publish necessary

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebosch natebosch merged commit 4e9615e into master May 24, 2023
66 checks passed
@natebosch natebosch deleted the logger-compat branch May 24, 2023 00:09
jakemac53 pushed a commit that referenced this pull request May 24, 2023
Fixes #3514

Add a forwarding implementation of `onLevelChanged` which was added in
the `Logger` class.

Update upper bound SDK constraint to avoid pub publish warning.

Remove `dependency_overrides` section in `pubspec.yaml` since there is a
separate overrides file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildForInputLogger needs to be updated for latest pkg:logger
2 participants