Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a top level pubspec to silence the analysis_options.yaml diagnostic #3485

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

jakemac53
Copy link
Contributor

Up for discussion, it isn't super ideal but I don't know of a simpler/better option. Getting quite tired of having the persistent diagnostic that package:lints can't be resolved.

One alternative is creating a whole subdirectory instead and moving the file there, but then it wouldn't apply automatically to all packages, we would have to manually add an analysis_options.yaml to each and import that one, and may forget to do so when adding new packages.

One advantage of the alternative approach though would be that we would get a warning if forgetting to include package:lints from any given package (they do each have to add it or else the import doesn't resolve correctly).

@natebosch
Copy link
Member

We could also consider putting a copy of the file in each package directory with some automation to ensure it's kept in sync, perhaps with mono repo? cc @kevmoo

Or does it work to put symlinks in each package directory?

I'd be fine with this approach too - I don't have strong opinions about what the top level directory of the repo looks like.

@jakemac53
Copy link
Contributor Author

For now I think this is the simplest option

@jakemac53 jakemac53 merged commit a34aa32 into master Apr 17, 2023
66 checks passed
@jakemac53 jakemac53 deleted the top-level-package branch April 17, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants