Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention JSON format in dart2js args error message #3414

Merged
merged 1 commit into from Dec 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_web_compilers/CHANGELOG.md
@@ -1,3 +1,7 @@
## 3.2.8-dev

- Mention JSON formatting in error message about dart2js args.

## 3.2.7

- Migrate off deprecated analyzer apis.
Expand Down
7 changes: 5 additions & 2 deletions build_web_compilers/lib/src/web_entrypoint_builder.dart
Expand Up @@ -99,8 +99,11 @@ class WebEntrypointBuilder implements Builder {
}

if (options.config[_dart2jsArgsOption] is! List) {
throw ArgumentError.value(options.config[_dart2jsArgsOption],
_dart2jsArgsOption, 'Expected a list for $_dart2jsArgsOption.');
var message = options.config[_dart2jsArgsOption] is String
? 'There may have been a failure decoding as JSON, expected a list'
: 'Expected a list';
throw ArgumentError.value(
options.config[_dart2jsArgsOption], _dart2jsArgsOption, message);
}
var dart2JsArgs = (options.config[_dart2jsArgsOption] as List?)
?.map((arg) => '$arg')
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 3.2.7
version: 3.2.8-dev
description: Builder implementations wrapping the dart2js and DDC compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers

Expand Down