Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependency on frontend_server_client #3383

Merged
merged 2 commits into from Oct 18, 2022
Merged

Bump dependency on frontend_server_client #3383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a3d22
Bump dependency on frontend_server_client
natebosch Oct 18, 2022
3e18bb7
Another non-null var
natebosch Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_runner/CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,7 @@
## 2.3.1

- Upgrade to `frontend_service_client` version 3.

## 2.3.0

- Add `-d` as a shorthand for `--delete-conflicting-outputs`.
Expand Down
6 changes: 2 additions & 4 deletions build_runner/lib/src/build_script_generate/bootstrap.dart
View file
Open in desktop
Expand Up @@ -165,13 +165,11 @@ Future<int> _createKernelIfNeeded(Logger logger) async {
await logTimedAsync(logger, 'Precompiling build script...', () async {
try {
final result = await client.compile();
hadErrors = result == null ||
result.errorCount > 0 ||
!(await kernelCacheFile.exists());
hadErrors = result.errorCount > 0 || !(await kernelCacheFile.exists());

// Note: We're logging all output with a single log call to keep
// annotated source spans intact.
final logOutput = result?.compilerOutputLines.join('\n');
final logOutput = result.compilerOutputLines.join('\n');
if (logOutput != null && logOutput.isNotEmpty) {
hadOutput = true;
if (hadErrors) {
Expand Down
4 changes: 2 additions & 2 deletions build_runner/pubspec.yaml
View file
Open in desktop
@@ -1,5 +1,5 @@
name: build_runner
version: 2.3.0
version: 2.3.1
description: A build system for Dart code generation and modular compilation.
repository: https://github.com/dart-lang/build/tree/master/build_runner

Expand All @@ -19,7 +19,7 @@ dependencies:
collection: ^1.15.0
crypto: ^3.0.0
dart_style: ^2.0.0
frontend_server_client: ^2.1.0
frontend_server_client: ^3.0.0
glob: ^2.0.0
graphs: ^2.0.0
http_multi_server: ^3.0.0
Expand Down