Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt some old tests into null safety #3317

Merged
merged 2 commits into from Jun 3, 2022
Merged

opt some old tests into null safety #3317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a5f9c0
opt some old tests into null safety
jakemac53 Jun 3, 2022
2e9a20b
opt in a build_test test as well
jakemac53 Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion build_runner/test/entrypoint/run_test.dart
View file
Open in desktop
Expand Up @@ -36,7 +36,6 @@ void main() {
),
d.dir('test', [
d.file('hello_test.dart', '''
// @dart=2.9
import 'package:test/test.dart';
main() {
test('hello', () {});
Expand Down
4 changes: 1 addition & 3 deletions build_runner/test/integration_tests/utils/build_descriptor.dart
View file
Open in desktop
Expand Up @@ -151,7 +151,6 @@ Future<BuildTool> packageWithBuildScript(
String _buildersFile(
Iterable<TestBuilderDefinition> builders, Uri callingScript) =>
'''
// @dart=2.9
import 'package:build/build.dart';
import 'package:build_test/build_test.dart';

Expand All @@ -166,7 +165,6 @@ String _builderFactory(TestBuilderDefinition builder) =>
String _buildToolFile(
Iterable<TestBuilderDefinition> builders, Uri callingScript) =>
'''
// @dart=2.9
import 'dart:io';

import 'package:build/build.dart';
Expand Down Expand Up @@ -236,7 +234,7 @@ d.FileDescriptor _pubspec(String name,
var buffer = StringBuffer()
..writeln('name: $name')
..writeln('environment:')
..writeln(' sdk: ">=2.9.0 <3.0.0"');
..writeln(' sdk: ">=2.12.0 <3.0.0"');

void writeDeps(String group) {
buffer.writeln(group);
Expand Down