Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support null stack traces coming from the build_runner script isolate #3260

Merged
merged 2 commits into from Mar 14, 2022
Merged

support null stack traces coming from the build_runner script isolate #3260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0010650
support null stack traces coming from the build_runner script isolate
jakemac53 Mar 14, 2022
510a330
format with the latest dartfmt
jakemac53 Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions build_daemon/lib/constants.dart
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ const versionSkew = 'DIFFERENT RUNNING VERSION';
const optionsSkew = 'DIFFERENT OPTIONS';

const buildModeFlag = 'build-mode';

enum BuildMode {
// ignore: constant_identifier_names
Manual,
Expand Down
4 changes: 3 additions & 1 deletion build_runner/CHANGELOG.md
View file
Open in desktop
@@ -1,4 +1,6 @@
## 2.1.8-dev
## 2.1.8

- Support null stack traces coming from the build runner script isolate.

## 2.1.7

Expand Down
2 changes: 1 addition & 1 deletion build_runner/lib/src/build_script_generate/bootstrap.dart
View file
Open in desktop
Expand Up @@ -74,7 +74,7 @@ Future<int> generateAndRun(
messagePort = ReceivePort();
errorListener = errorPort.listen((e) {
final error = e[0] as Object? ?? NullThrownError();
final trace = Trace.parse(e[1] as String).terse;
final trace = Trace.parse(e[1] as String? ?? '').terse;

handleUncaughtError(error, trace);
if (scriptExitCode == 0) scriptExitCode = 1;
Expand Down
2 changes: 1 addition & 1 deletion build_runner/pubspec.yaml
View file
Open in desktop
@@ -1,5 +1,5 @@
name: build_runner
version: 2.1.8-dev
version: 2.1.8
description: A build system for Dart code generation and modular compilation.
repository: https://github.com/dart-lang/build/tree/master/build_runner

Expand Down