Skip to content

Commit

Permalink
run dart2js through 'dart compile js' instead of its snapshot (#3338)
Browse files Browse the repository at this point in the history
  • Loading branch information
jakemac53 committed Jul 19, 2022
1 parent 0d71620 commit f1a7de8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
4 changes: 3 additions & 1 deletion build_web_compilers/CHANGELOG.md
@@ -1,4 +1,6 @@
## 3.2.4-dev
## 3.2.4

- Use `dart compile js` instead of running dart2js from its sdk snapshot.

## 3.2.3

Expand Down
5 changes: 3 additions & 2 deletions build_web_compilers/lib/src/dart2js_bootstrap.dart
Expand Up @@ -99,12 +99,13 @@ https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-ski
]);
}

log.info('Running dart2js with ${args.join(' ')}\n');
log.info('Running `dart compile js` with ${args.join(' ')}\n');
var result = await Process.run(
p.join(sdkDir, 'bin', 'dart'),
[
..._dart2jsVmArgs,
p.join(sdkDir, 'bin', 'snapshots', 'dart2js.dart.snapshot'),
'compile',
'js',
...args,
],
workingDirectory: scratchSpace.tempDir.path);
Expand Down
4 changes: 2 additions & 2 deletions build_web_compilers/pubspec.yaml
@@ -1,10 +1,10 @@
name: build_web_compilers
version: 3.2.4-dev
version: 3.2.4
description: Builder implementations wrapping Dart compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers

environment:
sdk: ">=2.14.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"

dependencies:
analyzer: ">=1.0.0 <5.0.0"
Expand Down

0 comments on commit f1a7de8

Please sign in to comment.