Skip to content

Commit

Permalink
Await and skip a missed broken expectation (#3253)
Browse files Browse the repository at this point in the history
These expectations can fail as an unhandled async error and the
exception lost because of the error handling zone running the `Builder`.
The test should have been failing, add a `skip` for now instead of
silently failing the test.
  • Loading branch information
natebosch committed Mar 9, 2022
1 parent d916c44 commit bac6d4a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions build_resolvers/test/resolver_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,14 @@ void main() {

test('are included in library stream', () {
return _runWith((resolver) async {
expect(resolver.libraries.map((l) => l.name), neverEmits('other'));
await expectLater(
resolver.libraries.map((l) => l.name), neverEmits('other'));

await resolver.libraryFor(entryPoint);

expect(resolver.libraries.map((l) => l.name), emits('other'));
await expectLater(
resolver.libraries.map((l) => l.name), emits('other'),
skip: 'https://github.com/dart-lang/build/issues/3256');
});
});

Expand Down

0 comments on commit bac6d4a

Please sign in to comment.