Skip to content

Commit

Permalink
Still cannot get "enabled: false" to impact the generated "build.dart…
Browse files Browse the repository at this point in the history
…" file
  • Loading branch information
BenVercammen committed Oct 18, 2023
1 parent 3261128 commit b879dfb
Show file tree
Hide file tree
Showing 6 changed files with 64 additions and 0 deletions.
6 changes: 6 additions & 0 deletions _test/build.yaml
Expand Up @@ -11,3 +11,9 @@ targets:
- test/hello_world_custom_html_test.dart.browser_test.dart
- test/other_test.dart.browser_test.dart
- test/sub-dir/subdir_test.dart.browser_test.dart
# HELP: the settings below won't have any effect on the builders applied in `build.dart`
provides_builder|not_enabled_builder:
enabled: false
# HELP: Only when adding (even an empty) `other_builder.build.yaml` file, the builder won't show up in `build.dart`
other_builder|other_builder:
enabled: false
5 changes: 5 additions & 0 deletions _test/other_builder.build.yaml
@@ -0,0 +1,5 @@
#---
## disable all inherited "provides_builder" builders...
#targets:
# $default:
# auto_apply_builders: false
5 changes: 5 additions & 0 deletions _test/pkgs/other_builder/build.yaml
@@ -0,0 +1,5 @@
builders:
other_builder:
import: "package:provides_builder/builders.dart"
builder_factories: ["someBuilder"]
build_extensions: {".dart": [".something.dart"]}
36 changes: 36 additions & 0 deletions _test/pkgs/other_builder/lib/builders.dart
@@ -0,0 +1,36 @@
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';

import 'package:build/build.dart';

class _SomeBuilder implements Builder {
const _SomeBuilder();

factory _SomeBuilder.fromOptions(BuilderOptions options) {
if (options.config['throw_in_constructor'] == true) {
throw StateError('Throwing on purpose cause you asked for it!');
}
return const _SomeBuilder();
}

@override
final buildExtensions = const {
'.dart': ['.something.dart']
};

@override
Future build(BuildStep buildStep) async {
if (!await buildStep.canRead(buildStep.inputId)) return;

await buildStep.writeAsBytes(
buildStep.inputId.changeExtension('.something.dart'),
buildStep.readAsBytes(buildStep.inputId));
}
}


Builder otherBuilder(BuilderOptions options) =>
_SomeBuilder.fromOptions(options);
10 changes: 10 additions & 0 deletions _test/pkgs/other_builder/pubspec.yaml
@@ -0,0 +1,10 @@
name: other_builder

environment:
sdk: ^3.0.0

dependencies:
build:
path: ../../../build
provides_builder:
path: ../provides_builder
2 changes: 2 additions & 0 deletions _test/pubspec.yaml
Expand Up @@ -16,6 +16,8 @@ dev_dependencies:
build_web_compilers: any
dart_flutter_team_lints: ^2.0.0
io: ^1.0.0
other_builder:
path: pkgs/other_builder/
path: ^1.8.0
provides_builder:
path: pkgs/provides_builder/
Expand Down

0 comments on commit b879dfb

Please sign in to comment.