Skip to content

Commit

Permalink
support null stack traces coming from the build_runner script isolate (
Browse files Browse the repository at this point in the history
  • Loading branch information
jakemac53 committed Mar 14, 2022
1 parent 6ccafdf commit a387d70
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions build_daemon/lib/constants.dart
Expand Up @@ -11,6 +11,7 @@ const versionSkew = 'DIFFERENT RUNNING VERSION';
const optionsSkew = 'DIFFERENT OPTIONS';

const buildModeFlag = 'build-mode';

enum BuildMode {
// ignore: constant_identifier_names
Manual,
Expand Down
4 changes: 3 additions & 1 deletion build_runner/CHANGELOG.md
@@ -1,4 +1,6 @@
## 2.1.8-dev
## 2.1.8

- Support null stack traces coming from the build runner script isolate.

## 2.1.7

Expand Down
2 changes: 1 addition & 1 deletion build_runner/lib/src/build_script_generate/bootstrap.dart
Expand Up @@ -74,7 +74,7 @@ Future<int> generateAndRun(
messagePort = ReceivePort();
errorListener = errorPort.listen((e) {
final error = e[0] as Object? ?? NullThrownError();
final trace = Trace.parse(e[1] as String).terse;
final trace = Trace.parse(e[1] as String? ?? '').terse;

handleUncaughtError(error, trace);
if (scriptExitCode == 0) scriptExitCode = 1;
Expand Down
2 changes: 1 addition & 1 deletion build_runner/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_runner
version: 2.1.8-dev
version: 2.1.8
description: A build system for Dart code generation and modular compilation.
repository: https://github.com/dart-lang/build/tree/master/build_runner

Expand Down

0 comments on commit a387d70

Please sign in to comment.