Skip to content

Commit

Permalink
Use non-null result
Browse files Browse the repository at this point in the history
Make a version bump instead of range expansion.
  • Loading branch information
natebosch committed Oct 18, 2022
1 parent 52444f3 commit 3c0a329
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build_runner/CHANGELOG.md
@@ -1,6 +1,6 @@
## 2.3.1

- Allow `frontend_servier_client` version 3.
- Upgrade to `frontend_service_client` version 3.

## 2.3.0

Expand Down
6 changes: 2 additions & 4 deletions build_runner/lib/src/build_script_generate/bootstrap.dart
Expand Up @@ -165,13 +165,11 @@ Future<int> _createKernelIfNeeded(Logger logger) async {
await logTimedAsync(logger, 'Precompiling build script...', () async {
try {
final result = await client.compile();
hadErrors = result == null ||
result.errorCount > 0 ||
!(await kernelCacheFile.exists());
hadErrors = result.errorCount > 0 || !(await kernelCacheFile.exists());

// Note: We're logging all output with a single log call to keep
// annotated source spans intact.
final logOutput = result?.compilerOutputLines.join('\n');
final logOutput = result.compilerOutputLines.join('\n');
if (logOutput != null && logOutput.isNotEmpty) {
hadOutput = true;
if (hadErrors) {
Expand Down
2 changes: 1 addition & 1 deletion build_runner/pubspec.yaml
Expand Up @@ -19,7 +19,7 @@ dependencies:
collection: ^1.15.0
crypto: ^3.0.0
dart_style: ^2.0.0
frontend_server_client: ">=2.1.0 <4.0.0"
frontend_server_client: ^3.0.0
glob: ^2.0.0
graphs: ^2.0.0
http_multi_server: ^3.0.0
Expand Down

0 comments on commit 3c0a329

Please sign in to comment.