Skip to content

Commit

Permalink
Use dart instead of pub (#3244)
Browse files Browse the repository at this point in the history
* change the build_test to use dart run instead of pub run

* remove other references to pub
  • Loading branch information
jakemac53 committed Feb 14, 2022
1 parent 4a91391 commit 2d36ee3
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 6 deletions.
4 changes: 4 additions & 0 deletions build_daemon/CHANGELOG.md
@@ -1,3 +1,7 @@
## 3.0.3-dev

- Updated the example to use `dart pub` instead of `pub`.

## 3.0.2

- Run `serveRequests` in an error zone and forward errors to the clients.
Expand Down
2 changes: 1 addition & 1 deletion build_daemon/example/example.dart
Expand Up @@ -20,7 +20,7 @@ void main(List<String> args) async {
client = await BuildDaemonClient.connect(
workingDirectory,
[
'pub',
'dart',
'run',
'build_runner',
'daemon',
Expand Down
2 changes: 1 addition & 1 deletion build_daemon/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_daemon
version: 3.0.2
version: 3.0.3-dev
description: A daemon for running Dart builds.
repository: https://github.com/dart-lang/build/tree/master/build_daemon

Expand Down
2 changes: 1 addition & 1 deletion build_modules/test/build_test.dart
Expand Up @@ -33,7 +33,7 @@ void main() {
expect(_changedGeneratedFiles(), isEmpty);

// 2 - run build - should be no output, since nothing should change
var result = _runProc('pub${Platform.isWindows ? '.bat' : ''}',
var result = _runProc('dart',
['run', 'build_runner', 'build', '--delete-conflicting-outputs']);
expect(result,
contains(RegExp(r'Succeeded after \S+( \S+)? with \d+ outputs')));
Expand Down
2 changes: 2 additions & 0 deletions build_resolvers/CHANGELOG.md
@@ -1,5 +1,7 @@
## 2.0.7-dev

- Updated error messages to use `dart pub` instead of `pub`.

## 2.0.6

- Allow the latest analyzer.
Expand Down
2 changes: 1 addition & 1 deletion build_resolvers/lib/src/resolver.dart
Expand Up @@ -472,7 +472,7 @@ https://github.com/dart-lang/sdk/issues/new with the title
''');
} else {
var upgradeCommand =
isFlutter ? 'flutter packages upgrade' : 'pub upgrade';
isFlutter ? 'flutter packages upgrade' : 'dart pub upgrade';
log.warning('''
Your current `analyzer` version may not fully support your current SDK version.
Expand Down
2 changes: 2 additions & 0 deletions build_runner/CHANGELOG.md
@@ -1,3 +1,5 @@
## 2.1.8-dev

## 2.1.7

- Allow the latest `pkg:build`.
Expand Down
2 changes: 1 addition & 1 deletion build_runner/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_runner
version: 2.1.7
version: 2.1.8-dev
description: A build system for Dart code generation and modular compilation.
repository: https://github.com/dart-lang/build/tree/master/build_runner

Expand Down
Expand Up @@ -106,7 +106,7 @@ Future<BuildTool> package(Iterable<d.Descriptor> otherPackages,
]).create();
await Future.wait(otherPackages.map((d) => d.create()));
await pubGet('a');
return BuildTool._('pub', ['run', 'build_runner']);
return BuildTool._('dart', ['run', 'build_runner']);
}

/// Create a package in [d.sandbox] with a `tool/build.dart` script using
Expand Down

0 comments on commit 2d36ee3

Please sign in to comment.