Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: --reporter=json for check-unnecessary-nullable crashes, saying Converting object to an encodable object failed: Instance of 'MappedIterable<FormalParameter, String>' #980

Merged
merged 3 commits into from Aug 30, 2022

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Aug 29, 2022

…nverting object to an encodable object failed: Instance of 'MappedIterable<FormalParameter, String>' #979

What is the purpose of this pull request? (put an "X" next to an item)

Close #979

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

…nverting object to an encodable object failed: Instance of 'MappedIterable<FormalParameter, String>' dart-code-checker#979
@incendial incendial self-requested a review August 30, 2022 06:01
@incendial incendial changed the title Fix bug --reporter=json for check-unnecessary-nullable crashes, saying Converting object to an encodable object failed: Instance of 'MappedIterable<FormalParameter, String>' fix: --reporter=json for check-unnecessary-nullable crashes, saying Converting object to an encodable object failed: Instance of 'MappedIterable<FormalParameter, String>' Aug 30, 2022
@incendial
Copy link
Member

@fzyzcjy thank you so much for the fix, could you please update the changelog and I'll merge it?

@incendial incendial added this to the 4.18.0 milestone Aug 30, 2022
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Aug 30, 2022

Done

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #980 (9ac6ccc) into master (8c1637d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files         311      311           
  Lines        6519     6519           
=======================================
  Hits         5720     5720           
  Misses        799      799           
Impacted Files Coverage Δ
..._list/json/unnecessary_nullable_json_reporter.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 5372467 into dart-code-checker:master Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants