Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: avoid-top-level-members-in-tests #945

Merged
merged 1 commit into from Aug 30, 2022
Merged

fix: avoid-top-level-members-in-tests #945

merged 1 commit into from Aug 30, 2022

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Jul 26, 2022

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

Issues: #944

What changes did you make? (Give an overview)

I added all the folders ('*') so that only the test folder is taken into account.

Is there anything you'd like reviewers to focus on?

I tried to do a test to see if the file was being ignored, but I have the impression that the exclusion is done in another part of the code.

As it stands, this is the only rule that doesn't take excludes in parameters.
Is this normal?
We could add the excludes of the config or replace the existing excludes.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #945 (30929dd) into master (4152cd7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 30929dd differs from pull request most recent head fd7f74a. Consider uploading reports for the commit fd7f74a to get more accurate results

@@           Coverage Diff           @@
##           master     #945   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         312      312           
  Lines        6518     6518           
=======================================
  Hits         5720     5720           
  Misses        798      798           
Impacted Files Coverage Δ
...n_tests/avoid_top_level_members_in_tests_rule.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@lsaudon
Copy link
Contributor Author

lsaudon commented Jul 28, 2022

I don't know why it was Publish test results that failed.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@incendial incendial added this to the 4.18.0 milestone Aug 14, 2022
@incendial incendial merged commit 4a686da into dart-code-checker:master Aug 30, 2022
@lsaudon lsaudon deleted the issue-811 branch August 30, 2022 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants