feat: add new rule avoid-banned-imports & modify prefer-extracting-callbacks allow short callbacks to exist
#868
Conversation
# Conflicts: # CHANGELOG.md
lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_banned_imports/utils/config_parser.dart
Show resolved
Hide resolved
lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_banned_imports/visitor.dart
Outdated
Show resolved
Hide resolved
|
@roman-petrov do you want to participate in the review? |
I think that this is not necessary: I already reviewed the implementation and I think it covers majority of cases we need to start with. |
|
I am going to implement other features (e.g. #873)... So if this is not merged, two features will be in one single PR. |
fzyzcjy
changed the title
avoid-banned-imports & modify prefer-extracting-callbacks allow short callbacks to exist
|
ready for review |
There was a problem hiding this comment.
Sorry for the long delay, left a few small comments. Also, could you add ignores for the dependency_validator as listed here https://pub.dev/packages/dependency_validator#configuration ?
..._analyzer/rules/rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks_rule.dart
Show resolved
Hide resolved
lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart
Show resolved
Hide resolved
|
@fzyzcjy will you be able to take a look at the comments above? if not, it's totally okay, I can address them myself (you already did a great job!) |
|
Oh I forgot it... I have been busy recently so maybe have no time to fix the minor issues above. |
Sure, will fix it myself then |
#820
#866
#873
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[x] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?