Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: avoid-border-all is triggered even when it is not a const #841

Merged
merged 2 commits into from May 16, 2022

Conversation

vlkonoshenko
Copy link
Member

@vlkonoshenko vlkonoshenko commented May 10, 2022

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#837

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@vlkonoshenko vlkonoshenko self-assigned this May 10, 2022
@github-actions
Copy link

github-actions bot commented May 10, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented May 10, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 424

  • Total lines of source code: 7448

  • Total classes: 290

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1318.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #841 (2a67942) into master (f6758f9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 2a67942 differs from pull request most recent head 920a9b9. Consider uploading reports for the commit 920a9b9 to get more accurate results

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
+ Coverage   87.25%   87.32%   +0.07%     
==========================================
  Files         279      279              
  Lines        5932     5934       +2     
==========================================
+ Hits         5176     5182       +6     
+ Misses        756      752       -4     
Impacted Files Coverage Δ
...zer/rules/rules_list/avoid_border_all/visitor.dart 100.00% <100.00%> (ø)
...metrics/metrics_list/number_of_methods_metric.dart 100.00% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6758f9...920a9b9. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 20422aa into master May 16, 2022
@dkrutskikh dkrutskikh deleted the 837_fix_border_all branch May 16, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants