Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

feat: avoid-non-ascii-symbols rule #825

Merged
merged 4 commits into from May 3, 2022
Merged

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#819

@incendial incendial added type: enhancement New feature or request area-rules labels May 1, 2022
@incendial incendial added this to the 4.15.0 milestone May 1, 2022
@incendial incendial requested a review from dkrutskikh May 1, 2022 12:19
@incendial incendial self-assigned this May 1, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented May 1, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 424

  • Total lines of source code: 7442

  • Total classes: 290

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1318.0 hours

  • Found issues: 6 ⚠

@incendial
Copy link
Member Author

@fzyzcjy fyi, hope I got the idea right

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #825 (8313346) into master (374f392) will increase coverage by 0.01%.
The diff coverage is 95.83%.

❗ Current head 8313346 differs from pull request most recent head 20392e1. Consider uploading reports for the commit 20392e1 to get more accurate results

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
+ Coverage   87.28%   87.30%   +0.01%     
==========================================
  Files         277      279       +2     
  Lines        5907     5922      +15     
==========================================
+ Hits         5156     5170      +14     
- Misses        751      752       +1     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 94.31% <0.00%> (-1.09%) ⬇️
...on_ascii_symbols/avoid_non_ascii_symbols_rule.dart 100.00% <100.00%> (ø)
...es/rules_list/avoid_non_ascii_symbols/visitor.dart 100.00% <100.00%> (ø)
...ib/src/config_builder/models/analysis_options.dart 91.04% <0.00%> (-0.63%) ⬇️
lib/src/utils/node_utils.dart 100.00% <0.00%> (ø)
...es/rules_list/prefer_immediate_return/visitor.dart 100.00% <0.00%> (ø)
...immediate_return/prefer_immediate_return_rule.dart 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374f392...20392e1. Read the comment docs.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented May 1, 2022

@fzyzcjy fyi, hope I got the idea right

Sure, the idea is right

@dkrutskikh dkrutskikh merged commit ded9d0e into master May 3, 2022
@dkrutskikh dkrutskikh deleted the avoid-non-ascii-symbols branch May 3, 2022 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants