Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly handle disabling rules with false #822

Merged
merged 3 commits into from May 2, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added this to the 4.15.0 milestone Apr 30, 2022
@incendial incendial self-assigned this Apr 30, 2022
@github-actions
Copy link

github-actions bot commented Apr 30, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Apr 30, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 421

  • Total lines of source code: 7405

  • Total classes: 288

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1302.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #822 (0e07796) into master (43a293a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   87.26%   87.27%   +0.01%     
==========================================
  Files         277      277              
  Lines        5898     5903       +5     
==========================================
+ Hits         5147     5152       +5     
  Misses        751      751              
Impacted Files Coverage Δ
...ib/src/config_builder/models/analysis_options.dart 91.66% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5260f2a...0e07796. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 5f224b4 into master May 2, 2022
@dkrutskikh dkrutskikh deleted the fix-disabling-rules branch May 2, 2022 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants