Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: dart-code-metrics crash saying Bad state: No element when running command #805

Merged
merged 3 commits into from Apr 19, 2022

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Apr 18, 2022

Hi thanks for this flutter-favorite package! It is crashing because of .max on empty array. So here is the fix.

Closes #804

@fzyzcjy fzyzcjy changed the title Fix dart-code-metrics crash saying Bad state: No element when running command fix: dart-code-metrics crash saying Bad state: No element when running command Apr 18, 2022
@incendial
Copy link
Member

@fzyzcjy thanks again for you contribution! Can you please update the changelog too?

@incendial
Copy link
Member

Now formatting is broken, can you fix that too?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Apr 19, 2022

@incendial Done

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #805 (6c6c50a) into master (240d317) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files         277      277           
  Lines        5898     5898           
=======================================
  Hits         5147     5147           
  Misses        751      751           
Impacted Files Coverage Δ
...rc/analyzers/lint_analyzer/utils/report_utils.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16936d5...6c6c50a. Read the comment docs.

@incendial incendial merged commit dab7f56 into dart-code-checker:master Apr 19, 2022
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented May 1, 2022

Look forward to releasing a new version :)

@incendial
Copy link
Member

Plan to release it tomorrow 👍

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented May 1, 2022

looking forward to the release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dart-code-metrics crash saying Bad state: No element when running command
2 participants