Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: unpin pytest in CI #30

Merged

Conversation

tylerjereddy
Copy link
Collaborator

Fixes #24

Fixed regression where --import-mode=importlib used together with
PYTHONPATH{.interpreted-text role="envvar"} or
pythonpath{.interpreted-text role="confval"} would cause import errors
in test suites.
  • so try unpinning the pytest version we use in CI

* `pytest` `7.1.0` was just released:
https://github.com/pytest-dev/pytest/releases/tag/7.1.0

* release notes indicate:

```
Fixed regression where --import-mode=importlib used together with
PYTHONPATH{.interpreted-text role="envvar"} or
pythonpath{.interpreted-text role="confval"} would cause import errors
in test suites.
```

* so try unpinning the `pytest` version we use in CI
@tylerjereddy
Copy link
Collaborator Author

Python 3.6 support was dropped by pytest in this version as well:

pytest-dev/pytest#9437: Dropped support for Python 3.6, which reached end-of-life at 2021-12-23.

We should probably apply pressure to drop 3.6 pretty soon too IMO. In the interim, I suppose the pytest version pin could remain in place for Python 3.6 only...

@shanedsnyder shanedsnyder reopened this Jun 7, 2022
@shanedsnyder
Copy link
Contributor

Let's see if we can get this working with 3.6 support dropped..

@shanedsnyder shanedsnyder merged commit 0ece831 into darshan-hpc:main Dec 16, 2022
@tylerjereddy tylerjereddy deleted the treddy_issue_24_unpin_pytest branch December 16, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pytest version 7.0.1 causing CI jobs to fail
2 participants