Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only activate if -vv used #10

Merged
merged 2 commits into from Jan 23, 2020
Merged

Only activate if -vv used #10

merged 2 commits into from Jan 23, 2020

Conversation

ionelmc
Copy link
Contributor

@ionelmc ionelmc commented Jan 13, 2020

Fixes #7.

@blueyed
Copy link
Contributor

blueyed commented Jan 13, 2020

Fixes #8, not #7, right?

I think it is good in general - messing with user options is not a good idea. It could be however get activated/used still.

Related: pytest-dev/pytest#5932, pytest-dev/pytest#5933

@ionelmc
Copy link
Contributor Author

ionelmc commented Jan 13, 2020

Well actually ... both :)

@blueyed
Copy link
Contributor

blueyed commented Jan 13, 2020

So adding -vv that way breaks xdist then somehow?

@darrenburns
Copy link
Owner

Thanks for this! Very interesting that this is what seemed to cause the xdist incompatibility...

I'll try and have a look over the weekend.

@darrenburns darrenburns merged commit 8091bc7 into darrenburns:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict with pytest-xdist
3 participants
@ionelmc @blueyed @darrenburns