Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup fasthttp #3434

Merged
merged 1 commit into from Jul 14, 2021
Merged

Pickup fasthttp #3434

merged 1 commit into from Jul 14, 2021

Conversation

wcs1only
Copy link
Contributor

@wcs1only wcs1only commented Jul 14, 2021

Description

Picking up the lastest version of fasthttp. It contains a bugfix that we reported upstream.

I did review for changes since 1.21 here:
https://github.com/valyala/fasthttp/releases

I did not find any warning of breaking changes, it appears to be mostly minor improvements and bugfixes since our last release.

Issue reference

valyala/fasthttp#1043

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #3434 (69dba5d) into master (032f108) will increase coverage by 0.71%.
The diff coverage is 70.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3434      +/-   ##
==========================================
+ Coverage   58.50%   59.21%   +0.71%     
==========================================
  Files          84       96      +12     
  Lines        7611     8482     +871     
==========================================
+ Hits         4453     5023     +570     
- Misses       2848     3103     +255     
- Partials      310      356      +46     
Impacted Files Coverage Δ
cmd/placement/config.go 27.02% <ø> (ø)
cmd/placement/main.go 0.00% <ø> (ø)
pkg/components/bindings/registry.go 100.00% <ø> (ø)
pkg/components/kubernetes_loader.go 50.00% <ø> (ø)
pkg/components/middleware/http/registry.go 100.00% <ø> (ø)
pkg/components/nameresolution/registry.go 100.00% <ø> (ø)
pkg/components/pubsub/registry.go 100.00% <ø> (ø)
pkg/components/secretstores/registry.go 100.00% <ø> (ø)
pkg/components/standalone_loader.go 61.81% <ø> (ø)
pkg/credentials/certchain.go 0.00% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f81853...69dba5d. Read the comment docs.

Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcs1only wcs1only merged commit 1a3c441 into dapr:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants