Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cert test): bump cert test deps to match main go mod ones #3410

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented May 3, 2024

Description

I keep seeing an issue in my other PR bc of these dependencies. Want to separate the fix to here.
#3324

rror: /home/runner/go/pkg/mod/github.com/dapr/dapr@v1.13.2/pkg/runtime/hotreload/loader/disk/resource.go:33:21: not enough type arguments for type Batcher: have 1, want 2
Error: /home/runner/go/pkg/mod/github.com/dapr/dapr@v1.13.2/pkg/runtime/hotreload/loader/disk/resource.go:48:31: cannot infer T (/home/runner/go/pkg/mod/github.com/dapr/kit@v0.13.1-0.20240416202840-ccffb60016c7/events/batcher/batcher.go:50:24)

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

berndverst and others added 2 commits April 30, 2024 16:10
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
@berndverst
Copy link
Member

You have to run make modtidy-all for linter and build to pass.

3346.patch Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this patch file should be part of this PR :)

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants