Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable consumer group identification for client #3405

Closed

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Apr 26, 2024

Description

We should be able to see client id and consumer id information on our clients, especially since we already have this information readily available to us through existing metadata fields.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: Samantha Coyle <sam@diagrid.io>
@sicoyle sicoyle requested review from a team as code owners April 26, 2024 16:38
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several Kafka conformance/certification tests failed with this change. Please make sure this does not have adverse effects and verify all Kafka certification and conformance tests pass with the change.

Signed-off-by: Samantha Coyle <sam@diagrid.io>
…sicoyle/components-contrib into fix-kafka-consumer-group-identification
@sicoyle
Copy link
Contributor Author

sicoyle commented May 15, 2024

will come back to this later after looking into it a bit more

@sicoyle sicoyle closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants