Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to generate signed url in gcp bucket #3393

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bhagya05
Copy link

@bhagya05 bhagya05 commented Apr 9, 2024

Description

Added ability to generate signed url from GCP bucket

Issue reference

Please reference the issue this PR will close: #2862

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@bhagya05 bhagya05 requested review from a team as code owners April 9, 2024 12:21
Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@yaron2
Copy link
Member

yaron2 commented May 14, 2024

@bhagya05 can you please add the signTTL metadata item here? https://github.com/dapr/components-contrib/blob/main/bindings/gcp/bucket/metadata.yaml

Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@bhagya05
Copy link
Author

@yaron2 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable signed url in GCP Storage Bucket
2 participants