New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka PubSub: Propagate partition key to DLT #3368
Kafka PubSub: Propagate partition key to DLT #3368
Conversation
…afka pubsub Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
… using bulk subscribe in kafka pubsub, and fixed entry metadata not passed to the DLT Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
e680c82
to
08ae60f
Compare
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Seems like the certification tests for RabbitMQ and MQTT3 are failing, I assume that this is a known issue? |
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Signed-off-by: denisbchrsk <155584191+denisbchrsk@users.noreply.github.com>
Hey @yaron2 @berndverst, The issue with the partition key not being propagated to the DLT in Kafka pubsub is a blocker for us from using Dapr's Kafka pubsub, as DLTs are important for us to be able to handle errors separately. |
This will be reviewed soon and if accepted will make it to the upcoming release |
Thanks for your contribution @denisbchrsk |
Description
Added support for partition key propagation to DLT when subscribing (including bulk subscribe) to a Kafka pubsub, by utilizing the enriched metadata from the subscribed message and use it to determine the partition key of the message produced to the DLT (utilizing the metadata which is added to the message in the
doCallback
anddoBulkCallback
according to this merged PR #3289).Another change which was done in order to implement the partition key propagation when using bulk subscribe in Kafka, was passing each individual message's metadata to the DLT.
Previously, only the bulk request's metadata was considered when publishing to DLT, changing that allowed similar implementation added to
Publish
to be viable inBulkPublish
as well.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2227
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: