Fix context used in kafka consume

[jjcollinge]

Signed-off-by: Joni Collinge jonathancollinge@live.com

Description

Use the consume context in the backoff retry of consume as the context parameter will be cancelled and not renewed.

Without this change the subscription does not recover once the context has been refreshed and no more messages are consumed.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

[codecov]

Codecov Report

Attention: Patch coverage is 30.23256% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 35.26%. Comparing base (e45dcba) to head (6b7c966).
Report is 10 commits behind head on main.

❗ Current head 6b7c966 differs from pull request most recent head 383d336. Consider uploading reports for the commit 383d336 to get more accurate results

Files	Patch %	Lines
common/component/azure/eventhubs/eventhubs.go	0.00%	25 Missing ⚠️
common/authentication/azure/auth.go	33.33%	10 Missing and 2 partials ⚠️
state/redis/redis_query.go	33.33%	12 Missing ⚠️
common/component/kafka/consumer.go	0.00%	7 Missing ⚠️
configuration/azure/appconfig/appconfig.go	87.50%	1 Missing and 1 partial ⚠️
common/component/kafka/kafka.go	0.00%	1 Missing ⚠️
state/postgresql/v2/postgresql.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3366   +/-   ##
=======================================
  Coverage   35.26%   35.26%           
=======================================
  Files         244      244           
  Lines       30969    30969           
=======================================
+ Hits        10921    10922    +1     
  Misses      19116    19116           
+ Partials      932      931    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ItalyPaleAle]

Looks like the Kafka conformance tests are failing, can you PTAL?

[yaron2]

Looks like the Kafka conformance tests are failing, can you PTAL?

They still need fixing from an earlier PR. Some tests need to be removed as they checked for non conformant behavior where messages were still expected to be delivered after the subscription was cancelled

[jjcollinge]

@yaron2 I ended up removing the stop subscribers test. It looked to me that the test didn't have much value once we removed the logic to receive messages after the subscribe contexts had been cancelled. Let me know if you want me to reinstate it.

[ItalyPaleAle]

@yaron2 I ended up removing the stop subscribers test. It looked to me that the test didn't have much value once we removed the logic to receive messages after the subscribe contexts had been cancelled. Let me know if you want me to reinstate it.

Wait please don't remove the entire test. There's a reason for that test, we want to make sure that context cancellation works!

[berndverst]

This PR should be made against main branch and then cherry picked.

In contrib we do not merge release back to main.

Can you change the base branch @jjcollinge

[berndverst]

@yaron2 advised this is not going to be merged for 1.13. So I will update your base branch for that reason also.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!