Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Blobstorage Binding and State Store: Migrate to Track2 Azure SDK #2290

Merged
merged 16 commits into from Nov 29, 2022

Conversation

berndverst
Copy link
Member

Signed-off-by: Bernd Verst 4535280+berndverst@users.noreply.github.com

Description

Azure Blobstorage Binding: Migrate to Track2 Azure SDK

Fixes #1530

@berndverst berndverst requested review from a team as code owners November 17, 2022 10:07
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 17, 2022

Components certification test

🔗 Link to Action run

Commit ref: ff89913

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.blobstorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 17, 2022

Components conformance test

🔗 Link to Action run

Commit ref: ff89913

✅ All conformance tests passed

All tests have reported a successful status

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2290 (d28a289) into master (287c068) will increase coverage by 0.12%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##           master    #2290      +/-   ##
==========================================
+ Coverage   38.14%   38.27%   +0.12%     
==========================================
  Files         199      202       +3     
  Lines       25484    25469      -15     
==========================================
+ Hits         9721     9748      +27     
+ Misses      14994    14958      -36     
+ Partials      769      763       -6     
Impacted Files Coverage Δ
internal/component/azure/blobstorage/client.go 7.24% <7.24%> (ø)
state/azure/blobstorage/blobstorage.go 19.84% <8.69%> (-10.71%) ⬇️
bindings/azure/blobstorage/blobstorage.go 10.90% <9.21%> (-15.12%) ⬇️
internal/component/azure/blobstorage/request.go 66.17% <66.17%> (ø)
internal/component/azure/blobstorage/metadata.go 85.36% <85.36%> (ø)
nameresolution/mdns/mdns.go 73.82% <0.00%> (+0.33%) ⬆️
state/in-memory/in_memory.go 41.25% <0.00%> (+2.97%) ⬆️
configuration/azure/appconfig/appconfig.go 73.68% <0.00%> (+12.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 17, 2022

Components certification test

🔗 Link to Action run

Commit ref: b0bcb14

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 17, 2022

Components conformance test

🔗 Link to Action run

Commit ref: b0bcb14

✅ All conformance tests passed

All tests have reported a successful status

bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst berndverst changed the title Azure Blobstorage Binding: Migrate to Track2 Azure SDK Azure Blobstorage Binding and State Store: Migrate to Track2 Azure SDK Nov 18, 2022
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components conformance test

🔗 Link to Action run

Commit ref: 70eb9f3

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components certification test

🔗 Link to Action run

Commit ref: 70eb9f3

❌ Some certification tests failed

These tests failed:

  • pubsub.kafka
  • bindings.azure.eventhubs

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components certification test

🔗 Link to Action run

Commit ref: 8811d5e

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.blobstorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components conformance test

🔗 Link to Action run

Commit ref: 8811d5e

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.blobstorage

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components certification test

🔗 Link to Action run

Commit ref: f11fc24

❌ Some certification tests failed

These tests failed:

  • bindings.kafka
  • bindings.azure.eventhubs
  • bindings.azure.blobstorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 18, 2022

Components conformance test

🔗 Link to Action run

Commit ref: f11fc24

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.blobstorage

@berndverst
Copy link
Member Author

Somehow the refactoring in commit 8811d5e introduced a huge performance regression for the binding.

Will have to look into it tomorrow, or revert.

state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Show resolved Hide resolved
state/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 19, 2022

Components certification test

🔗 Link to Action run

Commit ref: 23d36a0

❌ Some certification tests failed

These tests failed:

  • bindings.kafka
  • bindings.azure.eventhubs
  • bindings.azure.blobstorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 19, 2022

Components conformance test

🔗 Link to Action run

Commit ref: 23d36a0

✅ All conformance tests passed

All tests have reported a successful status

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 21, 2022

Components certification test

🔗 Link to Action run

Commit ref: f1b9374

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.blobstorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 21, 2022

Components conformance test

🔗 Link to Action run

Commit ref: f1b9374

✅ All conformance tests passed

All tests have reported a successful status

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 23, 2022

Components conformance test

🔗 Link to Action run

Commit ref: 7d5c06b

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 23, 2022

Components certification test

🔗 Link to Action run

Commit ref: 7d5c06b

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • pubsub.azure.eventhubs

ItalyPaleAle
ItalyPaleAle previously approved these changes Nov 28, 2022
bindings/azure/blobstorage/blobstorage.go Outdated Show resolved Hide resolved
@berndverst berndverst merged commit 9826fa9 into dapr:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure][Track 2 SDK] Migrate Azure Blob Storage Binding
3 participants