Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mqtt component to upstream #2207

Merged
merged 2 commits into from Oct 21, 2022
Merged

Conversation

shivamkm07
Copy link
Contributor

Signed-off-by: shivam shivamkm07@gmail.com

Description

The fix in upstream mqtt component for disabling autoack was merged recently(eclipse/paho.mqtt.golang#578). The PR upgrades the mqtt component to use the upstream instead of the fork

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: shivam <shivamkm07@gmail.com>
@shivamkm07 shivamkm07 marked this pull request as ready for review October 21, 2022 10:01
@shivamkm07 shivamkm07 requested review from a team as code owners October 21, 2022 10:02
@mukundansundar
Copy link
Contributor

@shivamkm07 do we know as to when the next patch release will be ? And can we use that instead of master commit?

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2207 (bbae625) into master (0326f13) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2207   +/-   ##
=======================================
  Coverage   37.55%   37.55%           
=======================================
  Files         193      193           
  Lines       24743    24742    -1     
=======================================
  Hits         9293     9293           
+ Misses      14738    14737    -1     
  Partials      712      712           
Impacted Files Coverage Δ
pubsub/mqtt/mqtt.go 12.42% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shivamkm07
Copy link
Contributor Author

@shivamkm07 do we know as to when the next patch release will be ? And can we use that instead of master commit?

I don't see any milestone tagged in https://github.com/eclipse/paho.mqtt.golang. I have pinged the maintainer though, would update when I get the response.

@berndverst berndverst added this to the v1.10 milestone Oct 21, 2022
@berndverst berndverst merged commit 05b1423 into dapr:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants