Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary replace statements in go.mod #2185

Merged
merged 3 commits into from Oct 12, 2022
Merged

Remove unnecessary replace statements in go.mod #2185

merged 3 commits into from Oct 12, 2022

Conversation

berndverst
Copy link
Member

Description

Remove unnecessary replace statements in go.mod

@berndverst
do not pin kubernetes client
58b1ec4 
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
remove unnecessary replace statements
5e896ec 
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst berndverst requested review from a team as code owners October 12, 2022 22:19
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 12, 2022 •
edited

Components conformance test

🔗 Link to Action run

Commit ref: 5e896ec

❌ Some conformance tests failed

These tests failed:

  • bindings.http
  • bindings.influx
  • bindings.kafka-wurstmeister
  • bindings.kafka-confluent
  • bindings.mqtt-emqx
  • bindings.mqtt-mosquitto
  • bindings.mqtt-vernemq
  • bindings.postgres
  • bindings.redis
  • bindings.rabbitmq
  • pubsub.aws.snssqs
  • pubsub.hazelcast
  • pubsub.in-memory
  • pubsub.mqtt-emqx
  • pubsub.mqtt-mosquitto
  • pubsub.mqtt-vernemq
  • pubsub.natsstreaming
  • pubsub.pulsar
  • pubsub.rabbitmq
  • pubsub.redis
  • pubsub.kafka-wurstmeister
  • pubsub.kafka-confluent
  • secretstores.kubernetes
  • secretstores.localenv
  • secretstores.localfile
  • secretstores.hashicorp.vault
  • state.cassandra
  • state.memcached
  • state.mongodb
  • state.mysql
  • state.postgresql
  • state.redis
  • state.sqlserver
  • state.cockroachdb
  • state.rethinkdb
  • state.azure.blobstorage
  • state.azure.cosmosdb
  • state.azure.sql
  • state.azure.tablestorage.storage
  • state.azure.tablestorage.cosmosdb
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus
  • bindings.azure.blobstorage
  • bindings.azure.eventgrid
  • bindings.azure.eventhubs
  • bindings.azure.servicebusqueues
  • bindings.azure.storagequeues
  • secretstores.azure.keyvault.certificate
  • secretstores.azure.keyvault.serviceprincipal
  • bindings.azure.cosmosdb

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 12, 2022 •
edited

Components certification test

🔗 Link to Action run

Commit ref: 5e896ec

❌ Some certification tests failed

These tests failed:

  • bindings.kafka
  • bindings.azure.storagequeues

ItalyPaleAle
ItalyPaleAle reviewed Oct 12, 2022
View reviewed changes
go.mod
@@ -374,12 +374,6 @@ require (
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace k8s.io/client => github.com/kubernetes-client/go v0.0.0-20190928040339-c757968c4c36

replace github.com/eclipse/paho.mqtt.golang => github.com/shivamkm07/paho.mqtt.golang v1.3.6-0.20220106130409-e28a1db639f8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not upstream already? It is unacceptable to use @shivamkm07's personal fork for so many months. We need to find a different strategy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version is 1.4.1 and we are stuck on this unmaintained 1.3.6 fork.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you complete work on eclipse/paho.mqtt.golang#578 @shivamkm07 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berndverst Updated the PR as requested. Waiting for the maintainers' response. Thanks!

@berndverst
don't remove mqtt replacement
c6b888e 
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 12, 2022 •
edited

Components conformance test

🔗 Link to Action run

Commit ref: c6b888e

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 12, 2022 •
edited

Components certification test

🔗 Link to Action run

Commit ref: c6b888e

❌ Some certification tests failed

These tests failed:

  • pubsub.kafka
  • pubsub.mqtt
  • bindings.kafka
  • bindings.azure.storagequeues

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2185 (c6b888e) into master (80adc9a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   37.38%   37.42%   +0.03%     
==========================================
  Files         191      191              
  Lines       24884    24884              
==========================================
+ Hits         9304     9313       +9     
+ Misses      14859    14849      -10     
- Partials      721      722       +1
Impacted Files Coverage Δ
state/in-memory/in_memory.go 46.00% <0.00%> (+3.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@berndverst berndverst merged commit 3427cc1 into dapr:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamkm07 shivamkm07 shivamkm07 left review comments

@ItalyPaleAle ItalyPaleAle ItalyPaleAle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@berndverst @dapr-bot @ItalyPaleAle @shivamkm07