Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15111 cq: fix thollander/actions-comment-pull-request #13820

Merged
merged 3 commits into from
Feb 22, 2024
Merged

DAOS-15111 cq: fix thollander/actions-comment-pull-request #13820

merged 3 commits into from
Feb 22, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: pr,vm

comment_includes is now comment_tag

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-15111 cq: fix thollander/actions-comment-pull-request
04817ac 
Test-tag: pr,vm

comment_includes is now comment_tag

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Update GHA to Node.js 20'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15111

daltonbohning added a commit that referenced this pull request Feb 21, 2024
@daltonbohning
DAOS-15111 cq: verify #13820
cf9d4d2 
Skip-test: true
Skip-tests: true
Skip-build: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Feb 21, 2024
@daltonbohning
DAOS-15111 cq: verify #13820
85011da 
Skip-test: true
Skip-tests: true
Skip-build: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Feb 21, 2024
@daltonbohning
DAOS-15111 cq: verify #13820
aec611b 
Skip-test: true
Skip-tests: true
Skip-build: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review February 22, 2024 16:14
@daltonbohning
Copy link
Contributor Author

Changes verified on #13845:
https://github.com/daos-stack/daos/actions/runs/7993214049

@ashleypittman
Copy link
Contributor

thollander/actions-comment-pull-request#160 looks to be the change that triggered this, what we're setting is now a tag rather than a string match on the comment, as such it's probably better to change the string as well so that it's meaningful as a tag.

You could probably also remove that string from the comment as well, it was only added there so that there was a substring which was always included so there was something to match.

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-15111…
a83e20b 
…-part2
@daltonbohning
use meaningful comment_tag
8f9dce9 
Skip-test: true
Skip-tests: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Feb 22, 2024
@daltonbohning
DAOS-15111 cq: verify #13820
3632fd5 
Skip-test: true
Skip-tests: true
Skip-build: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Update GHA to Node.js 20'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15111

@daltonbohning
Copy link
Contributor Author

Verified again: https://github.com/daos-stack/daos/actions/runs/8008062802

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 22, 2024
@daltonbohning daltonbohning requested a review from a team February 22, 2024 18:59
@daltonbohning
Copy link
Contributor Author

Jenkins testing was skipped since only a GHA was modified

@phender phender merged commit a2ec20e into master Feb 22, 2024
39 checks passed
@phender phender deleted the dbohning/daos-15111-part2 branch February 22, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleypittman ashleypittman ashleypittman approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@phender phender phender approved these changes

@brianjmurrell brianjmurrell Awaiting requested review from brianjmurrell

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
4 participants
@daltonbohning @ashleypittman @frostedcmos @phender