Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix local style linting #91

Conversation

spaceo
Copy link
Contributor

@spaceo spaceo commented Jul 11, 2022

Link to issue

https://reload.atlassian.net/browse/DDFSOEG-116

Description

Stylelint was not working properly.

For two reasons:


When PostCss was installed other problems arose:
Github actions were throwing both prettier errors and ts eslint errors
Various changes was made in order to address those errors.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

@spaceo spaceo force-pushed the feature/fix-local-style-linting branch 3 times, most recently from be94592 to c478155 Compare July 11, 2022 16:38
@spaceo spaceo requested a review from kasperbirch1 July 11, 2022 16:49
@spaceo spaceo force-pushed the feature/fix-local-style-linting branch from c478155 to 2aa5f24 Compare July 11, 2022 18:54
@spaceo spaceo merged commit 2d60fc3 into danskernesdigitalebibliotek:release/3 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants