Converted MissingPropertyType to property issue (vimeo#4099)

Fixes vimeo#2200
danog · Jan 29, 2021 · ee029a6 · ee029a6
1 parent 529a19d
commit ee029a6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/config.xsd b/config.xsd
@@ -265,7 +265,7 @@
             <xs:element name="MissingFile" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="MissingImmutableAnnotation" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="MissingParamType" type="IssueHandlerType" minOccurs="0" />
-            <xs:element name="MissingPropertyType" type="IssueHandlerType" minOccurs="0" />
+            <xs:element name="MissingPropertyType" type="PropertyIssueHandlerType" minOccurs="0" />
             <xs:element name="MissingReturnType" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="MissingTemplateParam" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="MissingThrowsDocblock" type="IssueHandlerType" minOccurs="0" />

diff --git a/src/Psalm/Internal/Analyzer/ClassAnalyzer.php b/src/Psalm/Internal/Analyzer/ClassAnalyzer.php
@@ -1710,7 +1710,8 @@ private function checkForMissingPropertyType(
             if (IssueBuffer::accepts(
                 new MissingPropertyType(
                     $message,
-                    new CodeLocation($source, $stmt->props[0]->name)
+                    new CodeLocation($source, $stmt->props[0]->name),
+                    $property_id
                 ),
                 $this->source->getSuppressedIssues()
             )) {

diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/InstancePropertyFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/InstancePropertyFetchAnalyzer.php
@@ -965,7 +965,8 @@ public static function analyze(
                         new MissingPropertyType(
                             'Property ' . $fq_class_name . '::$' . $prop_name
                                 . ' does not have a declared type',
-                            new CodeLocation($statements_analyzer->getSource(), $stmt)
+                            new CodeLocation($statements_analyzer->getSource(), $stmt),
+                            $property_id
                         ),
                         $statements_analyzer->getSuppressedIssues()
                     )) {

diff --git a/src/Psalm/Issue/MissingPropertyType.php b/src/Psalm/Issue/MissingPropertyType.php
@@ -1,7 +1,7 @@
 <?php
 namespace Psalm\Issue;
 
-class MissingPropertyType extends CodeIssue
+class MissingPropertyType extends PropertyIssue
 {
     const ERROR_LEVEL = 2;
     const SHORTCODE = 45;